Workaround for CI failure due to Data.bytes not being present.#1521
Merged
Conversation
grynspan
added
bug
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
Contributor
Author
harlanhaskins
approved these changes
Feb 3, 2026
Contributor
Author
|
Wasm issues are known/unrelated. |
stmontgomery
approved these changes
Feb 3, 2026
stmontgomery
left a comment
stmontgomery
left a comment
Contributor
There was a problem hiding this comment.
Makes sense, and my only concern is whether there are other failures lurking after this one. The Swift CI run should confirm
Contributor
Author
|
That's the only use of AFAIK other stuff should be fine, but we'll find out. |
grynspan
force-pushed
the
jgrynspan/workaround-for-data-rawspan-ci-failure
branch
from
54884c7 to
fc183e8
Compare
Contributor
Author
|
Toolchain build isn't 100% complete, but Swift Testing built successfully so that's all we were looking for. |
swift-ci still uses an older Xcode version with an older OS SDK that does not include `Data.bytes`. As a result, Swift Testing fails to build for Apple platforms. Work around the issue by manually constructing a `RawSpan` in the relevant place. Resolves rdar://169480914.
grynspan
force-pushed
the
jgrynspan/workaround-for-data-rawspan-ci-failure
branch
from
fc183e8 to
70769fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swift-ci still uses an older Xcode version with an older OS SDK that does not include
Data.bytes. As a result, Swift Testing fails to build for Apple platforms. Work around the issue by getting an unsafe buffer from theDataand using the buffer'sRawSpaninstead of the data's.Resolves rdar://169480914.
Checklist: